Python3: all integers are now 64 bits integers and so if the target is a 32 bit integer we must always do the conversion#14
Open
sweinst wants to merge 1 commit intofkarb:masterfrom
sweinst:master
Open
Python3: all integers are now 64 bits integers and so if the target is a 32 bit integer we must always do the conversion#14sweinst wants to merge 1 commit intofkarb:masterfrom sweinst:master
sweinst wants to merge 1 commit intofkarb:masterfrom
sweinst:master
Conversation
…bit integer we must always do the conversion
Member
|
PyLong_AsLong returns a 32 bit long in python 3, so I don't think that your comment that all integers in python 3 are 64 bit is accurate (in fact the python integer type can be > than 64 bit as well). All python integer numbers are the python type 'long', but that is not the same as saying they're all the same as the C type 'long long'. |
Member
|
Looking at the code, I would think that removing the PyLong_Check for python3 would be a sufficient change? (Runtime.PyInt_AsLong calls PyLong_AsLong under python 3) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.