Replace unsafe componentWillReceiveProps with componentDidUpdate #370
Open
aakula-edmunds wants to merge 1 commit intofisshy:masterfrom
Open
Replace unsafe componentWillReceiveProps with componentDidUpdate #370aakula-edmunds wants to merge 1 commit intofisshy:masterfrom
aakula-edmunds wants to merge 1 commit intofisshy:masterfrom
Conversation
…o generate strict mode warnings
|
Currently there's a warning due componentWillReceiveProps, do you plan to merge this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace unsafe
componentWillReceivePropswithcomponentDidUpdateso as not to generate strict mode warnings