Fixed a bug handling max combinations#10
Open
GCastilho wants to merge 1 commit intofirstandthird:masterfrom
Open
Fixed a bug handling max combinations#10GCastilho wants to merge 1 commit intofirstandthird:masterfrom
GCastilho wants to merge 1 commit intofirstandthird:masterfrom
Conversation
-- Fixed a bug where max was not being handled properly with arrays bigger than 4 items
Author
|
So @jgallen23, any plans on reviewing this? |
Member
|
yes, will review next week |
Author
|
Any update, @jgallen23 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-- Fixed a bug discussed in #8 where 'max' was not being handled properly with arrays bigger than 4 items