Open
Conversation
mattsmithtaiko
approved these changes
Jan 7, 2025
Contributor
mattsmithtaiko
left a comment
mattsmithtaiko
left a comment
There was a problem hiding this comment.
I'll approve so we don't need to go back-and-forth on another review, but please address the comments first.
Contributor
There was a problem hiding this comment.
Remove this file. This is from the MacOS filesystem.
Contributor
There was a problem hiding this comment.
Why is this file's name inconsistent with the others? I.e., it doesn't start with welcome-to-. I don't have a strong preference on naming convention but let's make it consistent. Could also call each of them like design-welcome.md or design-landing.md since these are basically the welcome/landing pages from which you can navigate to other subpages.
Contributor
Author
|
added proposed changes (kept the welcome-to- convention for the landing pages) |
Co-authored-by: Dan36252 <Dan36252@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.