fix(auth): ensure verify phone number waits for timeout to complete#2302
Closed
russellwheatley wants to merge 1 commit intomasterfrom
Closed
fix(auth): ensure verify phone number waits for timeout to complete#2302russellwheatley wants to merge 1 commit intomasterfrom
russellwheatley wants to merge 1 commit intomasterfrom
Conversation
Member
Author
|
closing in favour of: #2303 Opened against next beta02 release branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2300
When using the same phone number to verify (i.e. call
verifyPhoneNumber()), if you use it before the timeout set on the phone provider has elapsed, theverifyPhoneNumber()call will hang and result in the loading screen never resolving.This PR:
The below is a recording of using the same phone number to verify within the timeout set (60 seconds), each time I try to move to verification code screen, it throws modal pop up with time left before cool down period is over, once the 60 seconds have elapsed, we are able to go to the verification code screen with the same number without verifyPhoneNumber() hanging.
Screen_recording_20260114_143153.webm