Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the Message property of a PreconditionFailedResult was not preserved when mapping to a different generic type. The fix ensures that when MapFailure<TOther>() is called on a PreconditionFailedResult<T>, both the Reason and Message are carried over to the new PreconditionFailedResult<TOther> instance, maintaining consistency with how other failure result types (like UnauthorizedResult) preserve their properties during type mapping.
- Updated
MapFailure<TOther>()to pass bothReasonandMessagewhen creating the mapped result - Added comprehensive test coverage validating that both properties are preserved across all precondition failure reasons
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/F23.Kernel/Result.cs | Fixed MapFailure<TOther>() method to include preconditionFailed.Message parameter when mapping PreconditionFailedResult to another type |
| src/F23.Kernel.Tests/Results/PreconditionFailedResultTests.cs | Added parametrized test to verify that both Reason and Message are preserved when mapping PreconditionFailedResult to another type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
paulirwin
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16