Skip to content

make cmake compile ok and cmake generate config.cmake ok which is used by find_package(cachelib) #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lrita wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −6
Open

make cmake compile ok and cmake generate config.cmake ok which is used by find_package(cachelib) #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cachelib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ set(BIN_INSTALL_DIR bin CACHE STRING
"The subdirectory where binaries should be installed")
set(TESTS_INSTALL_DIR tests CACHE STRING
"The subdirectory where test binaries should be installed")
set(INCLUDE_INSTALL_DIR include/cachelib CACHE STRING
set(INCLUDE_INSTALL_DIR include CACHE STRING
"The subdirectory where header files should be installed")
set(LIB_INSTALL_DIR lib CACHE STRING
"The subdirectory where libraries should be installed")
Expand Down Expand Up @@ -327,7 +327,7 @@ install(
datatype
navy
shm
DESTINATION ${INCLUDE_INSTALL_DIR}
DESTINATION ${INCLUDE_INSTALL_DIR}/cachelib/
FILES_MATCHING PATTERN "*.h"
PATTERN "external" EXCLUDE
PATTERN "tests" EXCLUDE
Expand All @@ -342,7 +342,7 @@ install(
DIRECTORY
${CACHELIB_BUILD}/cachelib/
DESTINATION
${INCLUDE_INSTALL_DIR}
${INCLUDE_INSTALL_DIR}/cachelib/
FILES_MATCHING
PATTERN "gen-cpp2/*.h"
PATTERN "gen-cpp2/*.tcc"
Expand Down
1 change: 1 addition & 0 deletions cachelib/benchmarks/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ if (BUILD_TESTS)
cachelib_datatype
cachelib_allocator
Folly::follybenchmark
Folly::folly_subprocess
glog::glog
gflags
GTest::gtest
Expand Down
6 changes: 3 additions & 3 deletions cachelib/common/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ target_link_libraries(cachelib_common PUBLIC
FBThrift::thriftprotocol
Folly::folly
Folly::follybenchmark
Folly::folly_exception_tracer
Folly::folly_exception_tracer_base
Folly::folly_exception_counter
Folly::folly_experimental_exception_tracer_exception_tracer
Folly::folly_experimental_exception_tracer_exception_tracer_base
Folly::folly_experimental_exception_tracer_exception_counter
GTest::gtest
${XXHASH_LIBRARY}
)
Expand Down