Fix Variable Names for P100(Max) Latency in Cachebench#368
Open
SuhoSon wants to merge 3 commits intofacebook:mainfrom
Open
Fix Variable Names for P100(Max) Latency in Cachebench#368SuhoSon wants to merge 3 commits intofacebook:mainfrom
SuhoSon wants to merge 3 commits intofacebook:mainfrom
Conversation
This commit fixes a bug where the P100 Latency is not displayed in the output of Cachebench. The cause of the bug was due to different variable names used for P100 Latency in Cachelib and Cachebench, and the variable name in Cachebench has been modified to match the variable name used in Cachelib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Debug
Cachelib is using variable name for p100 as max (cachelib/common/PercentileStats.cpp:72). But, Cachebench was using variable name for p100 as p100. So, I have changed Cachebench's variable name to max.
Result