[BUGFIX] Limit tax classes to current order#675
Open
andreashager wants to merge 1 commit intoextcode:mainfrom
Open
[BUGFIX] Limit tax classes to current order#675andreashager wants to merge 1 commit intoextcode:mainfrom
andreashager wants to merge 1 commit intoextcode:mainfrom
Conversation
Currently all tax classes from all orders are loaded instead of the specifc ones from current oder item only. This breaks expansion of TYPO3 IRRE element if you have a lot of orders.
andreashager
force-pushed
the
bugfix/master/limit-tax-classes
branch
from
adcc450 to
e9c7a88
Compare
Author
|
Any information missing? 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR limits the tax classes that are shown for each order product to the tax classes that are assigned to this order item. Otherwise all tax classes are shown (also from other orders).
If you have a lot of orders the inline elements does not expand anymore due to PHP memory allocation error.
If you need more information let me know 😊