Open
Conversation
Contributor
|
We should probably leave this here but deprecated for a fairly long time, at least a month or so. Otherwise PRs on tracks will fail unless they're all rebased. We could add a warning to the action too, though I'm not sure people read them. |
Contributor
|
My preference for this PR would be that we add the note to both READMEs but leave the action so that it doesn't break non-rebased PRs. Then we can delete the rest of it a few months from now (or never, idc) |
This reverts commit 12feb9a.
Contributor
Author
|
Ready for review, but ideally requires exercism/configlet#462 to be merged before this is merged. |
SleeplessByte
approved these changes
Dec 11, 2021
Member
SleeplessByte
left a comment
SleeplessByte
left a comment
There was a problem hiding this comment.
Approved, but prefer waiting for the other PR to get it merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #29
In draft until there is a decision on that issue about how to propagate the change to tracks.