Open
Conversation
- callers can pass in the optional variable `docker_build_script` - script should produce a Docker image - if the script variable is set the default Docker image build step isn't executed See exercism/java-test-runner#147 for context
Contributor
Author
|
Is there a recommended way to test this? |
Member
|
I have to think this through a bit, and that takes a bit more time with me no longer being employed at Exercism. There are a couple of things that spring to mind:
So I think we'd at least need to have a wrapper script to handle all this. That is, if @iHiD feels like this is worth the effort (and he's very busy right now). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker_build_scriptSee exercism/java-test-runner#147 for context
Would be nice to have caching, not sure how hard it is to add.