chore: Disable default features on some crates to unblock SP1 work#111
chore: Disable default features on some crates to unblock SP1 work#111tac0turtle merged 6 commits intoevstack:mainfrom
Conversation
Summary of ChangesHello @jonas089, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request facilitates the integration of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully addresses the stated objective of disabling default features on specific crates to avoid C-dependencies, which is necessary for compatibility with the SP1 toolchain. The modifications in Cargo.toml accurately reflect these changes, and the Cargo.lock file has been updated accordingly.
| alloy = { version = "=1.0.37", default-features = false, features = [ | ||
| "contract", | ||
| "providers", | ||
| "provider-http", | ||
| "signers", | ||
| "reqwest-rustls-tls", | ||
| ], default-features = false } | ||
| "sol-types", | ||
| ] } |
There was a problem hiding this comment.
The alloy dependency's feature set has been significantly reduced from ["contract", "providers", "provider-http", "signers", "reqwest-rustls-tls"] to ["contract", "sol-types"]. While this aligns with the goal of removing C-dependencies, please ensure that the removed features (especially providers, provider-http, and signers) are not implicitly relied upon by other parts of the evolve code within the SP1 context. If any functionality is missing, it might lead to runtime errors or unexpected behavior.
damiannolan
left a comment
There was a problem hiding this comment.
LGTM, cc @tac0turtle
| reth-payload-builder-primitives = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" } | ||
| reth-payload-primitives = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" } | ||
| reth-primitives = { git = "https://github.com/paradigmxyz/reth.git", tag = "v1.8.4" } | ||
| reth-primitives = { git = "https://github.com/paradigmxyz/reth.git", default-features = false, tag = "v1.8.4" } |
There was a problem hiding this comment.
This will be changed in #103, will it cause problems back?
There was a problem hiding this comment.
Do you know what APIs are required in #103? Are they part of a certain feature flag?
Worst case scenario we may have to juggle around some types to different crates. The main issue is bringing in C deps IIRC, as they are incompatible with sp1 zkvm
|
we are good to merge this, i tested on #103. |
The Interop team needs to import portions of the evolve code into the SP1 context to address recent changes in FeeHandler.
To enable this, several default features were disabled on specific crates to ensure no C-deps are pulled in, which can't be compiled by the SP1 toolchain.