Skip to content

chore: updating changelog to include telemetry options#3052

Merged
julienrbrt merged 3 commits intomainfrom
cian/add-telemetry-to-changelog
Feb 5, 2026
Merged

chore: updating changelog to include telemetry options#3052
julienrbrt merged 3 commits intomainfrom
cian/add-telemetry-to-changelog

Conversation

@chatton
Copy link
Contributor

@chatton chatton commented Feb 5, 2026

Overview

Add telemetry options to changelog

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chatton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on maintaining accurate project documentation by updating the CHANGELOG.md file. The update specifically adds a new entry under the 'Added' section to reflect the recent integration of OpenTelemetry tracing capabilities, ensuring that users and developers are informed about the new telemetry features and their configuration options.

Highlights

  • Changelog Update: The CHANGELOG.md file has been updated to include a new entry detailing the addition of OpenTelemetry tracing support.
  • OpenTelemetry Tracing: The new changelog entry highlights the implementation of OpenTelemetry tracing support with OTLP export, enabling distributed tracing across various ev-node components like block production, syncing, DA submission/retrieval, sequencer, store operations, and the RPC layer. It also mentions the configurable settings for this feature.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • CHANGELOG.md
    • Added a new entry under the 'Added' section to document the introduction of OpenTelemetry tracing support.
    • The entry details OTLP export for distributed tracing across ev-node components and lists the relevant configuration settings: instrumentation.tracing, instrumentation.tracing_endpoint, tracing_service_name, and instrumentation.tracing_sample_rate.
Activity
  • No human activity (comments, reviews, etc.) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@chatton chatton marked this pull request as ready for review February 5, 2026 10:28
@chatton chatton requested a review from auricom February 5, 2026 10:28
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedFeb 5, 2026, 2:55 PM

@claude
Copy link
Contributor

claude bot commented Feb 5, 2026

Claude finished @chatton's task in 1m 21s —— View job


Code Review Complete ✅

Todo List

  • Read CHANGELOG.md to understand the changes
  • Review configuration implementation to verify key naming
  • Validate the accuracy of the changelog entry
  • Provide comprehensive code review feedback

Review Summary

This PR adds a changelog entry documenting the OpenTelemetry tracing feature that was implemented in #2956. The PR has been merged and the change is accurate and well-documented.

Detailed Analysis

1. Code Quality & Architecture

  • The changelog entry correctly follows the Keep a Changelog format
  • Placed in the appropriate section (v1.0.0-rc.1### Added)
  • Uses consistent formatting with other entries in the changelog

2. Accuracy & Correctness

The configuration keys documented in the changelog are 100% accurate:

  • instrumentation.tracing - Confirmed in pkg/config/config.go:117
  • instrumentation.tracing_endpoint - Confirmed in pkg/config/config.go:119
  • instrumentation.tracing_service_name - Confirmed in pkg/config/config.go:121
  • instrumentation.tracing_sample_rate - Confirmed in pkg/config/config.go:123

All keys include the correct instrumentation. prefix, which matches the actual flag definitions in the codebase.

3. Documentation Completeness

The entry effectively communicates:

  • What: OpenTelemetry tracing support with OTLP export
  • Where: Lists all affected components (block production, syncing, DA submission/retrieval, sequencer, store operations, RPC layer)
  • How: Provides all configuration options needed to enable and configure the feature
  • Reference: Links to the original issue ([FEATURE] Add support for OLTP telemetry #2956)

4. Note on Previous Review Comment

The gemini-code-assist bot initially identified a concern about the tracing_service_name configuration key naming. However, this was already addressed in the second commit ("chore: pr feedback"). The final merged version correctly includes the instrumentation. prefix for all configuration keys.

Recommendations

While the PR is already merged and correct, for future reference:

  1. Consider Adding Example Configuration: Future changelog entries for configuration features could benefit from a brief example showing how to enable the feature:

    instrumentation:
      tracing: true
      tracing_endpoint: "localhost:4318"
      tracing_service_name: "my-rollup"
      tracing_sample_rate: 0.1
  2. Cross-reference Configuration Documentation: The changelog mentions that the feature is "Configurable via" these settings, but users might also benefit from a reference to the full configuration documentation (if it exists in docs/learn/config.md or similar).

Conclusion

This is a clean, accurate, and well-documented changelog update. The configuration key naming is correct, the scope is appropriate, and it follows the project's changelog conventions. No issues found.

Status: ✅ Approved (already merged)


Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the changelog to document the new OpenTelemetry tracing options. The change is good, but I found a small typo in one of the configuration keys listed. My review includes a suggestion to correct this for accuracy. I also noticed that the main configuration documentation in docs/learn/config.md doesn't include these new options yet; it would be beneficial to update it for completeness.

CHANGELOG.md Outdated

### Added

- Added OpenTelemetry tracing support with OTLP export for distributed tracing across ev-node components including block production, syncing, DA submission/retrieval, sequencer, store operations, and RPC layer. Configurable via `instrumentation.tracing`, `instrumentation.tracing_endpoint`, `tracing_service_name`, and `instrumentation.tracing_sample_rate` settings. ([#2956](https://github.com/evstack/ev-node/issues/2956))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a small inconsistency in the configuration key for tracing_service_name. Based on the configuration files (pkg/config/instrumentation.go and pkg/config/config.go), it should be prefixed with instrumentation. like the other tracing settings to ensure the documentation is accurate for users.

Suggested change
- Added OpenTelemetry tracing support with OTLP export for distributed tracing across ev-node components including block production, syncing, DA submission/retrieval, sequencer, store operations, and RPC layer. Configurable via `instrumentation.tracing`, `instrumentation.tracing_endpoint`, `tracing_service_name`, and `instrumentation.tracing_sample_rate` settings. ([#2956](https://github.com/evstack/ev-node/issues/2956))
- Added OpenTelemetry tracing support with OTLP export for distributed tracing across ev-node components including block production, syncing, DA submission/retrieval, sequencer, store operations, and RPC layer. Configurable via `instrumentation.tracing`, `instrumentation.tracing_endpoint`, `instrumentation.tracing_service_name`, and `instrumentation.tracing_sample_rate` settings. ([#2956](https://github.com/evstack/ev-node/issues/2956))

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.57%. Comparing base (b8eda5d) to head (f95c1d5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3052      +/-   ##
==========================================
- Coverage   56.63%   56.57%   -0.06%     
==========================================
  Files         118      118              
  Lines       12151    12151              
==========================================
- Hits         6882     6875       -7     
- Misses       4527     4534       +7     
  Partials      742      742              
Flag Coverage Δ
combined 56.57% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julienrbrt julienrbrt added this pull request to the merge queue Feb 5, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2026
@julienrbrt julienrbrt merged commit 0425059 into main Feb 5, 2026
13 of 17 checks passed
@julienrbrt julienrbrt deleted the cian/add-telemetry-to-changelog branch February 5, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants