Enable running ESM on Mac silicon using MPS#99
Merged
ebetica merged 6 commits intoevolutionaryscale:mainfrom Sep 19, 2025
Merged
Enable running ESM on Mac silicon using MPS#99ebetica merged 6 commits intoevolutionaryscale:mainfrom
ebetica merged 6 commits intoevolutionaryscale:mainfrom
Conversation
gjoliver
reviewed
Oct 7, 2024
Contributor
gjoliver
left a comment
There was a problem hiding this comment.
ha, this is very cool! thanks a lot for the PR.
can you revert the .gitignore changes? as a python package, we don't need to include dev env related things.
Contributor
Author
Removed .gitignore file |
Contributor
|
We have to set up a CLA before merging this PR 🙈 Sorry for not merging it for so long, I'll get to it hopefully soon. |
Contributor
Author
Any updates? |
Signed-off-by: Zeming Lin <ebetica0@gmail.com>
ebetica
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables ESM to run on Mac Silicon (M1, M2, M3) using the Metal Performance Shaders (MPS) backend for GPU training acceleration on Mac Silicon.
PyTorch already supports Mac (MPS): https://pytorch.org/docs/stable/notes/mps.html
Note that MPS does not support the embedding operations so the following environment variable has to be set to allow PyTorch to fallback for those operations:
export PYTORCH_ENABLE_MPS_FALLBACK=1There aren't any tests so I can't add a unit test for this by following an existing pattern. However I tested on my Macbook by running the following test and the above PR made this work.
This prints:
Model is running on device: mps:0confirming that MPS is being used.
And prints this warning that embedding operation fell back to CPU:
UserWarning: The operator 'aten::_embedding_bag' is not currently supported on the MPS backend and will fall back to run on the CPU. This may have performance implications.