fix: treat connection resets as connection closed by peer#110
Open
iloveitaly wants to merge 1 commit intoenvoy:masterfrom
Open
fix: treat connection resets as connection closed by peer#110iloveitaly wants to merge 1 commit intoenvoy:masterfrom
iloveitaly wants to merge 1 commit intoenvoy:masterfrom
Conversation
This was the original error message I received: Embassy/Transport.swift:203: Fatal error: Failed to send, errno=54, message=Connection reset by peer
Author
|
@fangpenlin thoughts on this? |
mikebuss
added a commit
to mikebuss/Embassy
that referenced
this pull request
Nov 20, 2024
|
I've also had this issue, but my fix involved changing handleRead to return if the read failed. For my use case, this solves the "Connection reset by peer" issue above. private func handleRead() {
// ensure we are not closed
guard !closed else {
return
}
guard reading else {
return
}
var data: Data!
do {
data = try socket.recv(size: Transport.recvChunkSize)
} catch {
return
}
guard data.count > 0 else {
closedByPeer()
return
}
// ensure we are not closing
guard !closing else {
return
}
if let callback = readDataCallback {
callback(data)
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was the original error message I received:
Embassy/Transport.swift:203: Fatal error: Failed to send, errno=54, message=Connection reset by peer