Change javax.xml.bind to org.apache.commons#3
Open
jszule wants to merge 3 commits intoemartech:masterfrom
Open
Change javax.xml.bind to org.apache.commons#3jszule wants to merge 3 commits intoemartech:masterfrom
jszule wants to merge 3 commits intoemartech:masterfrom
Conversation
jszule
commented
Apr 28, 2019
jszule
commented
- javax.xml.bind is deprecated: https://docs.oracle.com/javase/9/docs/api/java.xml.bind-summary.html
- the code also has a slightly better hash generation performance using the commons library
Contributor
|
Would you please rebase master and then I can check your modifications? Sorry for the late response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.