fix: gist history updating on gist action #1845
Open
+359
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixrieseberg
approved these changes
Feb 9, 2026
|
|
||
| class OctokitMock { | ||
| private static nextId = 1; | ||
| private static nextVersion = 1; |
Member
There was a problem hiding this comment.
Real nit: We might want to reset this between runs
codebytere
force-pushed
the
fix-history-update
branch
from
9742655 to
eab5583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1840
Fixes several bugs with gist history:
activeGistRevisionnow gets set correctly after publish/update operations, and the history dialog properly refreshes when revisions change. Also fixed the initial "Created" revision being incorrectly filtered out, and a state mutation bug that caused the revision list to display inconsistently.Also added a bunch more tests.