[ML] Better handling of invalid JSON state documents#2895
Open
edsavage wants to merge 6 commits intoelastic:mainfrom
Open
[ML] Better handling of invalid JSON state documents#2895edsavage wants to merge 6 commits intoelastic:mainfrom
edsavage wants to merge 6 commits intoelastic:mainfrom
Conversation
Various changes to the handling of errors when parsing JSON state documents to improve consistency and provide better visibility
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
valeriy42
reviewed
Jan 26, 2026
Contributor
valeriy42
left a comment
valeriy42
left a comment
There was a problem hiding this comment.
It looks mostly good. I have just a few minor comments.
| message = "Encountered NULL character in stream before parsing has started."; | ||
| ret = false; | ||
| } | ||
| if (m_Reader->handler().s_Type == SBoostJsonHandler::E_TokenObjectEnd) { |
Contributor
There was a problem hiding this comment.
Since both if statements could be true, you would potentially reassign message. I guess it should be either else if here, or the messages should be concatenated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various changes to the handling of errors when parsing JSON state documents to improve consistency and provide better visibility
Relates #2875