Add cross-restart reorg detection using Resume watermarks #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initialize ReorgAwareStream from resume_watermark to restore block hashes - Add hash mismatch detection: compare stored hash with server's prev_hash - Pass resume_watermark from client.py to ReorgAwareStream - Add 6 unit tests for cross-restart reorg detection scenarios This enables detecting chain reorgs that occur while the process is down by comparing the stored block hash (from state store) with the server's prev_hash.
incrypto32
force-pushed
the
krishna/cross-restart-reorg-detection
branch
from
8c79fc7 to
cdb1f28
Compare
fordN
reviewed
Feb 3, 2026
| ) | ||
|
|
||
| if is_reorg: | ||
| invalidation = BlockRange( |
Contributor
There was a problem hiding this comment.
Should we invalidate the entire previous range in this case to be safe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables detecting chain reorgs that occur while the process is down by comparing the stored block hash with the server's prev_hash.