Open
Conversation
drupol
requested changes
Nov 23, 2022
| public function send(NotificationInterface $notification): int; | ||
| public function send( | ||
| NotificationInterface $notification, | ||
| string $groupCode = NotificationService::GROUP_CODE_DEFAULT |
Member
There was a problem hiding this comment.
The constant GROUP_CODE_DEFAULT must be set in the interface, not in the concrete NotificationService implementation.
Member
|
I just rebased your branch to run the updated CI workflow that I added in |
Member
|
Could you please run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Follows #. Related to #. Fixes #.
Dears,
I have changed configuration structure and interface of NotificationService, to allow use multiple cns_group.
this patch will affect only existing configurations, but I leave there a default key, in send method, which means the source code of existing application wont be affected.
Kind Regards