Don't fetch starpls_server via bazel and fix vscode settings#39
Don't fetch starpls_server via bazel and fix vscode settings#39NEOatNHNG wants to merge 3 commits intoeclipse-score:mainfrom
Conversation
Also cleaned up vscode configuration.
It is already present in the devcontainer. Addresses eclipse-score/tooling#79
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
| // BasedPyright for python various type checking improvements and pylance features | ||
| "detachhead.basedpyright", | ||
| // Bazel BUILD integration | ||
| "bazelbuild.vscode-bazel", |
There was a problem hiding this comment.
This is incompatible with docs-as-code preview, that's why we did not include it. No idea if people use that preview feature or not.
There was a problem hiding this comment.
What do you mean with "docs-as-code preview"? I just tried to start bazel run :live_preview in a terminal and that still works as intended, as far as I can tell, even though that extension is installed.
At least for module development I guess I rather have a bazel integration than a live preview for my docs as code. Different story on document-heavy repos like eclipse-score/score of course.
| 99 | ||
| ], | ||
|
|
||
| // Exclude build, temp and cache folders |
There was a problem hiding this comment.
feels like this file (actually both) will be much harder to read without the newlines
There was a problem hiding this comment.
This is auto-format of the file in vscode. I mean we can also have some explicit non-default formatting but then we should create a formatting setting for JSON. I personally don't want to manually format files.
| "files.insertFinalNewline": false, | ||
| "files.trimFinalNewlines": false, | ||
| "files.trimTrailingWhitespace": false, |
There was a problem hiding this comment.
Those are patch files, so they shouldn't be modified automatically in any way. And whitespace matters in there.
Don't fetch starpls via bazel and use the one installed on the system or devcontainer instead.
Also clean up and fix some other vscode settings.
Related ticket
Addresses eclipse-score/tooling#79 (bugfix ticket)