This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix negative args and files without ending \n#3
Open
E5ten wants to merge 1 commit intodylanaraps:masterfrom
Open
Fix negative args and files without ending \n#3E5ten wants to merge 1 commit intodylanaraps:masterfrom
E5ten wants to merge 1 commit intodylanaraps:masterfrom
Conversation
If arg is negative, make the max lines it subtracted from the file length, like other head implementations Don't remove trailing newlines with mapfile, and don't add them with printf, to avoid printing an extra newline when a file doesn't end with one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support negative arguments to -n like some other head implementations, mapfile the whole file to get the total length and if the arg is negative, make the lines printed the arg added to the file length.
Don't remove trailing newlines with mapfile, and don't add them with printf, to avoid printing an extra newline when a file doesn't end with one.