Add support for non-compliant devices (+ minor improvements)#54
Add support for non-compliant devices (+ minor improvements)#54chkuendig wants to merge 5 commits intodudanov:mainfrom
Conversation
|
Hello, Thank you so much @chkuendig++, I tested the PR on my HA and now the elliptical bike is recognised. There are some unsupported data training but after remove the unsupported items the bike was added.
Could these items can be mapped/added to the supported ones? Regards, |
364f547 to
e209f2a
Compare
The movement_direction field in CrossTrainerData was missing model_meta(), causing it to be excluded from available_properties. This resulted in validation errors in the HA integration options flow.
|
@pafernanr I think I found the issue causing that error, try re-downloading the newest version ( fabde69 ) from my repo and see if that works. |
|
Hi, Sorry for the delay, I've been travelling for the last few days. I am not able to test it, even installing hassio-ftms using HACS shows next error message. The requirements cannot be installed. I'm not experienced with containters, but I think it could be related to the recentrly introduced "Docker Containerd Snapshotter" (https://github.com/home-assistant/operating-system/releases/tag/17.0)
|
|
That's an odd error, I didn't change anything related to how that works. Unfortunately I don't use HomeAssistant OS, so I can't reproduce this issue.
do you mean even the regular hassio-ftms branch (not my fork)? |
|
I was finally able to test last changes.
|

This is trying to solve the same issue as #49 but in a more generic way. I noticed various issues when trying to add my 2001 Sole F65. It lacks FTMS controls, doesn't advertise service_data and has a few other minor problems.
This adds a Unknown device type that's only to be used during discovery, to avoid some of the issues in #49 for devices where device type isn't clear before actually talking to them.
If anybody wants to test this: Just add https://github.com/chkuendig/hassio-ftms in HACS and install from there.
Details
Add Unknown device support for non-compliant FTMS devices
Some devices (e.g., Sole treadmills) advertise FTMS UUID but don't
provide proper service_data to determine machine type. This adds:
After type detection, Unknown proxies all calls to the real client type.
Add debug logging for live_properties
No impact in default config, but helps in case of issues
Add fw_version to device info with sw_version fallback
Don't ignore 0 values in realtime data
Changed truthiness checks to explicit None checks so that properties
with value 0 (like speed=0, distance=0) are not filtered out. This helps during detection if e.g. heart beat is not active/connected.