Conversation
Now if the backend version is higher than 6.5, it should get the sysdigcloud-values secret which include different settings such as JVM etc...
jameslarrea
left a comment
There was a problem hiding this comment.
Thanks @BuenClima! Looks good but the namespace should not be hardcoded because while the default the installer uses is sysdigcloud the customer can use any name. It gets set in the script here
You can see the other kubectl commands for examples.Also, minor but can we name the values file where this data will be stored imported_values.yaml?
jameslarrea
left a comment
There was a problem hiding this comment.
Not sure if the spacing inside the brackets will cause issues with some shells. Please update to show the spacing in all of them, like [[ $major -eq 6 ]]
Co-authored-by: Mark Breitung <mark.breitung@sysdig.com>
jameslarrea
left a comment
There was a problem hiding this comment.
the variable $version is not defined. There is an issue with BACKEND_VERSION being fixed here #237
But even then, seems that variable is not global but rather we run it every time we need to check the version. Let me discuss with @dark-vex tomorrow if maybe we can refactor that part a bit so it's cleaner.
Now if the backend version is higher than 6.5, it should get the sysdigcloud-values secret which include different settings such as JVM, etc...