Update LE.pm - Make use of the new use_pkcs1_oaep_padding function#103
Open
Refizul wants to merge 1 commit intodo-know:masterfrom
Open
Update LE.pm - Make use of the new use_pkcs1_oaep_padding function#103Refizul wants to merge 1 commit intodo-know:masterfrom
Refizul wants to merge 1 commit intodo-know:masterfrom
Conversation
Switched use_pkcs1_padding to use_pkcs1_oaep_padding to be compatible with the new version of Crypt::OpenSSL::RSA
sadt
suggested changes
Sep 13, 2025
There was a problem hiding this comment.
As someone said in issue's comments, it would be better to completely suppress the line and let the crypto library choose the default padding (which now is oaep anyway).
This would avoid the same problem arising again and again each time a padding mode becomes insecure.
ajmetz
added a commit
to ajmetz/Crypt-LE
that referenced
this pull request
Sep 30, 2025
[ 30/SEP/2025 AJMETZ ] - commented out line 674 ( $key->use_pkcs1_padding; ) following advice expressed in discussion of Git Issue 102 [ do-know#102 ] and feedback on an earlier pull request [ do-know#103 (review) ]. This will effectively delegate to Crypt::OpenSSL::RSA to set a default padding, and avoid the likes of errors such as: "PKCS#1 1.5 is disabled as it is known to be vulnerable to marvin attacks."
|
Have attempted to implement the feedback via #107 |
|
This will not fix the problem. oap is not a drop-in replacement for pkcs1. In Crypt::OpenSSL::RSA 0.37, we have added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched use_pkcs1_padding to use_pkcs1_oaep_padding to be compatible with the new version of Crypt::OpenSSL::RSA
FIXES #102