Open
Conversation
Contributor
Author
|
not sure how to properly generate those failing lockfiles |
nazarewk
changed the title
blaggacao
requested changes
Oct 17, 2024
Collaborator
blaggacao
left a comment
blaggacao
left a comment
There was a problem hiding this comment.
This looks great. However could we stay on a release branch for the main dependency?
We'll need to figure out why the manual re-locking is now failing in CI.
nazarewk
commented
Oct 18, 2024
| nixpkgs.writeScript "lefthook-${stage}" '' | ||
| #!${nixpkgs.runtimeShell} | ||
| [ "$LEFTHOOK" == "0" ] || ${lib.getExe nixpkgs.lefthook} run "${stage}" "$@" | ||
| [ "$LEFTHOOK" == "0" ] || ${lib.getExe nixpkgs.lefthook} run --no-auto-install "${stage}" "$@" |
Contributor
Author
There was a problem hiding this comment.
actually we could switch to 24.05 since it contains this flag implemented at https://github.com/evilmartians/lefthook/releases/tag/v1.6.11
Contributor
Author
It's actually pretty obvious and I don't know why it worked in the first place:
|
Collaborator
|
I (finally) made sure tests run on |
nazarewk
force-pushed
the
fix-old-lockfile
branch
from
056044b to
d446022
Compare
nazarewk
force-pushed
the
fix-old-lockfile
branch
from
d446022 to
f554a77
Compare
also adds some common excludes to treefmt
nazarewk
force-pushed
the
fix-old-lockfile
branch
from
f554a77 to
d13782e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stdto nixpkgs onnixos-unstableand applied a few repo tweaks