Added Module SUpport via Automatic Module Name and fixed the library …#14
Open
RealMangorage wants to merge 1 commit intodiscord-java:masterfrom
Open
Added Module SUpport via Automatic Module Name and fixed the library …#14RealMangorage wants to merge 1 commit intodiscord-java:masterfrom
RealMangorage wants to merge 1 commit intodiscord-java:masterfrom
Conversation
…finder to find resource via the classloader, so it will work in an module environment, can confirm works in non module enviroment (Java 8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Automatic Module Name to the Manifest file and updates the function for fetching a resource to one that works in a module environment, works for both module and non module environments.
Hope this helps :)