Closed
Conversation
|
Thank you for contributing! Unfortunately this repository does not accept external contributions yet. We are working on enabling this by aligning our internal processes and our CI setup to handle external contributions. However this will take some time to set up so in the meantime we unfortunately have to close this Pull Request. We hope you understand and will come back once we accept external PRs. — The DFINITY Foundation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix package name resolution for pinned dependencies (e.g.,
core@1)Fixes bug where dependencies with
@suffixes like"core@1" = "1.0.0"failed with "Package 'core@1' not found".Changes:
dep_base()helper to extract base package name before@"core"instead of"core@1")mo:core@1/IterMatches TypeScript implementation approach where the full name is kept throughout, with base name extraction only for API calls.