Open
Conversation
prathibhapadma
requested review from
SchettlerKoehler and
maybeec
as code owners
Comment on lines
40
to
42
| AWS - EKS: | ||
|
|
||
| helm upgrade --install nginx-ingress nginx-ingress-controller --set ingressClassResource.default=true --set containerSecurityContext.allowPrivilegeEscalation=false --repo https://charts.bitnami.com/bitnami --namespace nginx-ingress --create-namespace |
There was a problem hiding this comment.
I expected only AKS in this document and not AWS EKS
Author
There was a problem hiding this comment.
Modified document only for AKS
Comment on lines
5
to
9
| #adding azure addon annotation for http application routing | ||
| annotations: | ||
| {{- if contains $.Values.application.cloud "AWS" }} | ||
| {{ toYaml .Values.ingress.aws.annotations | indent 2 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Same here. The comment irritates me.
| @@ -1,5 +1,6 @@ | |||
| # Application configuration | |||
| application: | |||
| cloud: "" | |||
There was a problem hiding this comment.
I would define the possible values for cloud in a comment
…p_AKS.asciidoc updated with minor changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.