Make sure tags that mismatch pattern are not added#23
Open
thomasdegry wants to merge 3 commits intodevelopit:masterfrom
Open
Make sure tags that mismatch pattern are not added#23thomasdegry wants to merge 3 commits intodevelopit:masterfrom
thomasdegry wants to merge 3 commits intodevelopit:masterfrom
Conversation
Author
|
Awesome; anything else that needs to happen before we merge? |
ziadkh0
reviewed
May 21, 2017
src/tags-input.js
Outdated
| return false; | ||
| } | ||
|
|
||
| // Don't add if iti's invalid (eg, for pattern=) |
There was a problem hiding this comment.
Found a typo, "iti's" should be "it's"
Owner
|
I think we're good, just didn't want to do it on a plane haha |
Author
|
Awesome! Understandable 😄 |
|
Can we make a release for this? |
|
hmm there seems to be quite big fork in https://github.com/pirxpilot/tags-input |
|
@developit WTH... just do it already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20 and #21 to ensure that tags that don't get added if they mismatch with the pattern attribute.
This is just what @mikemaccana had but does not rely on include to ensure IE support. Got rid of the tilde trick and just check if
indexOfis equal or greater than 0.Also added some styles to flash the input box to indicate that the content is invalid.