Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for installing the charmbracelet/gum CLI tool as a devcontainer feature. It follows the established pattern in this repository for adding new features.
- Implements a new devcontainer feature for the
gumbinary from Charmbracelet - Uses GitHub releases to download and install the appropriate binary for the system architecture
- Includes automated testing to verify the installation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/charmbracelet-gum/devcontainer-feature.json | Defines the feature metadata with configurable version option |
| src/charmbracelet-gum/install.sh | Installation script that downloads and installs gum binary from GitHub releases |
| test/charmbracelet-gum/test.sh | Test script to verify gum is installed and functional |
| .github/workflows/test.yaml | Adds charmbracelet-gum to the CI test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # if [[ "$arch" == "aarch64" ]]; then | ||
| # arch="arm64" | ||
| # elif [[ "$arch" == "x86_64" ]]; then | ||
| # arch="x64" | ||
| # fi |
There was a problem hiding this comment.
The commented-out code for architecture mapping should be removed or implemented. The current implementation returns uname -m output directly (e.g., 'x86_64', 'aarch64'), which must match the naming convention used in the gum release archives. If the releases use different architecture names, this mapping logic should be uncommented and corrected.
| # if [[ "$arch" == "aarch64" ]]; then | |
| # arch="arm64" | |
| # elif [[ "$arch" == "x86_64" ]]; then | |
| # arch="x64" | |
| # fi | |
| if [[ "$arch" == "aarch64" ]]; then | |
| arch="arm64" | |
| elif [[ "$arch" == "x86_64" ]]; then | |
| arch="x64" | |
| fi |
| # arch="x64" | ||
| # fi | ||
| echo "$arch" | ||
| # echo "$(dpkg --print-architecture)" --- IGNORE --- |
There was a problem hiding this comment.
This commented-out line with '--- IGNORE ---' should be removed as it serves no purpose and clutters the code.
| # echo "$(dpkg --print-architecture)" --- IGNORE --- |
Closes #65