discriminate frames with virials labels in Multisystem class#294
discriminate frames with virials labels in Multisystem class#294PKUfjh wants to merge 2 commits intodeepmodeling:develfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #294 +/- ##
==========================================
- Coverage 81.57% 81.53% -0.04%
==========================================
Files 62 62
Lines 5244 5249 +5
==========================================
+ Hits 4278 4280 +2
- Misses 966 969 +3
Continue to review full report at Codecov.
|
wanghan-iapcm
left a comment
There was a problem hiding this comment.
This is a breaking change to the code that has potential influence on other codes using dpdata.MultiSystems with explicit formula.
I do not support the merging of this PR.
Actually this change just modifies the system names in the MultiSystems frames (add "_virials" to the system names), I do not see what negative influence this change will have on other codes. |
Sometimes we came across with multisystem (such as quip/gap/xyz format files) which has both frames with virials labels and frames without virials labels. The current implementation of the Multisystems class will lead to error message:
But this kind of Multisystems are in fact trainable, so I identify frames with virials in Multisystems, such that Systems will have names as:
The former represents systems with 60 carbon atoms without virials labels, the latter represents systems with 60 carbon atoms with virials labels.