Blockify everything, prefering HTML+blocks rather than patterns.#1
Open
Blockify everything, prefering HTML+blocks rather than patterns.#1
Conversation
0c3ce20 to
f1a0127
Compare
f1a0127 to
a287730
Compare
…on, which is insanely hacky, because variations are not supported by Gutenberg in any reasonable format.
dd32
added a commit
that referenced
this pull request
Apr 9, 2025
…`, `monthnum` and `day` fields. This includes: - `E_WARNING: Array to string conversion in wp-includes/post.php:6072` - `Uncaught TypeError: urldecode(): Argument #1 ($string) must be of type string, array given in wp-includes/post.php:6083` See https://core.trac.wordpress.org/ticket/62828 git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14416 74240141-8908-4e6f-9713-ba540dce6ec7
dd32
added a commit
that referenced
this pull request
Jan 20, 2026
…id PHP Fatal errors in `number_format_i18n()` calling `number_format()` with an empty string. Fixes fatals: > E_ERROR: Uncaught TypeError: number_format(): Argument #1 ($num) must be of type float, string given git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14635 74240141-8908-4e6f-9713-ba540dce6ec7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR'ing this against my own repo intentionally for a self-reminder. This is probably going to go stale very quickly, but that's OK.
This was a trial-run at removing some of the template-parts and using block templates instead instead of pattern hacking.
Things I ran into:
wp:queryworks, but I ran into shortcomings around the blocks available via it.wp:post-templateyou can set the className on the<ul>but you can't set the class on the<li>(which is what thepost_classis). This lead to a str_replace on the block render HTML to addplugin-cardto the plugin-cards, later fixed by using a different CSS selector instead.. Unable to add a class to query block list item WordPress/gutenberg#41441wp:post-templateyou can't define a "top level" block, so the "plugin-card" block is actually only the contents of the node that it would be rendered as, ie. it's all of the contents inside the<li>....</li>not including thelitags.<ul>to something like<div>. Usecore/post-templateto have each post render within<article>tags WordPress/gutenberg#37659wporg/missing-template-tageval block for this, and I quite like it as a hacky fixer.<!-- wp:wporg/missing-template-tag {"function":"the_archive_description","args":["<div class='taxonomy-description'>", "</div>"]} /--><!-- wp:wporg/missing-template-tag {"function":"the_posts_pagination"} /-->wp_headfires, so there's some customization on archive titles that doesn't apply to the block rendered header.query-titleblock which was laughable. See 9260f8f