fix: Remove setuptools from runtime dependencies #1372
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitri-yatsenko
force-pushed
the
fix/remove-setuptools-runtime-dep
branch
4 times, most recently
from
d026163 to
dd56823
Compare
Removed (unused in main package): - setuptools: Uses importlib.metadata.entry_points (stdlib) - urllib3: Only urllib.parse (stdlib) is used Moved to optional [viz] extra: - matplotlib: Only for Diagram.draw() - ipython: Only for Diagram.make_svg() in Jupyter Moved to test dependencies: - faker: Only used in test fixtures - matplotlib, ipython: Needed for diagram tests Install with visualization: pip install datajoint[viz] Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dimitri-yatsenko
force-pushed
the
fix/remove-setuptools-runtime-dep
branch
from
dd56823 to
222ad50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
setuptoolsfrom runtime dependencies - it's not needed.The codebase uses
importlib.metadata.entry_points(standard library since Python 3.8) for plugin discovery, notpkg_resourcesfrom setuptools.Test plan
🤖 Generated with Claude Code