fixes path issue when reading dumps from s3#435
Open
shaunakv1 wants to merge 2 commits intodatabacker:masterfrom
Open
fixes path issue when reading dumps from s3#435shaunakv1 wants to merge 2 commits intodatabacker:masterfrom
shaunakv1 wants to merge 2 commits intodatabacker:masterfrom
Conversation
Signed-off-by: shaunakv1 <shaunakv1@gmail.com>
deitch
requested changes
May 1, 2025
Collaborator
deitch
left a comment
deitch
left a comment
There was a problem hiding this comment.
The key change is fine, but it looks like your IDE reformatted some indentation incorrectly. Can you fix so the only change is in s3.go:78? Just running gofmt -w -s s3.go should do it.
Thanks for this PR.
Contributor
Author
|
ah, I should enable whitespace in my github diffs. Done! |
deitch
approved these changes
May 2, 2025
Collaborator
|
Looks good. Can you squash to a single commit, and sign it with |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #432