Skip to content

Migrate common package typescript #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hyperkid123 merged 5 commits into from
Feb 4, 2026
Merged

Migrate common package typescript #1550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3629044
chore: remove babel and ts config symlinks
Hyperkid123 Feb 2, 2026
ec8e009
fix(renderer): update wizard context types
Hyperkid123 Feb 2, 2026
757598d
fix(renderer): export use field api type
Hyperkid123 Feb 2, 2026
feb4e4c
feat(common): fully migrate to TS
Hyperkid123 Feb 2, 2026
2c0d87e
chore: remove affected runs in CI
Hyperkid123 Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ jobs:
with:
main-branch-name: 'master'

- name: Run build on affected projects
run: npx nx affected --target=build --parallel=3
- name: Run build on projects
run: npx nx run-many --target=build --parallel=3
Copy link
Collaborator

@karelhala karelhala Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to build all packages on a PR or just the ones affected ones?

Copy link
Member Author

@Hyperkid123 Hyperkid123 Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. You may miss some of TS issues. The projects are not properly wired yet so we need to build all until the migration is done.

continue-on-error: false

- name: Run lint on affected projects
run: npx nx affected --target=lint --parallel=3
- name: Run lint on projects
run: npx nx run-many --target=lint --parallel=3
continue-on-error: false

# - name: Run typecheck on affected projects
Expand All @@ -47,6 +47,6 @@ jobs:
- name: Clear Jest cache
run: npx jest --clearCache

- name: Run tests on affected projects
run: npx nx affected --target=test --parallel=3 --coverage
- name: Run tests projects
run: npx nx run-many --target=test --parallel=3 --coverage
continue-on-error: false
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ jobs:
with:
main-branch-name: 'master'

- name: Build affected packages
run: npx nx affected --target=build --parallel=3
- name: Build packages
run: npx nx run-many --target=build --parallel=3

- name: 🚀 Run Nx Release
run: |
Expand Down
47 changes: 3 additions & 44 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/ant-component-mapper/babel.config.js
View file
Open in desktop

This file was deleted.

Loading