fix(renderer): fix stringify#1408
Draft
rvsia wants to merge 1 commit intodata-driven-forms:masterfrom
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A new version (fix) will be released: v3.21.4 [DataDrivenFormsBot] |
Hyperkid123
reviewed
Sep 4, 2023
|
|
||
| return (value, allValues, ...options) => { | ||
| const key = stringify(value, allValues); | ||
| const key = stringify(allValues); |
Member
There was a problem hiding this comment.
We should do a try catch around the block if for some reason someone passes circular structure and the try/catch fails. Maybe with a console.error but do not crash the entire runtime.
Hyperkid123
force-pushed
the
master
branch
6 times, most recently
from
a3c287c to
2f9f5a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #(issue) (if applicable)
Description
Please include a summary of the change.
Schema (if applicable)
Checklist: (please see documentation page for more information)
Yarn buildpassesYarn lintpassesYarn testpassesfix|feat({scope}): {description}fix(pf3): wizard correctly handles next buttonFix button on documenation example page