fix: only silence warnings (not fatal errors)

[coolaj86]

Perhaps due to a change in he behavior of async.retry or perhaps by some other means, all connection errors (except verifying block warnings) are silenced on startup.

This means that any input that guarantees permanent failure - such as a wrong password or hostname or ip address or port - will just "sit there" without any feedback to the user.

Very confusing.

This changes the behavior so that the warning is logged and then ignored, but unexpected and fatal errors will throw.

If there are other non-fatal errors, then they can be added to the isNonFatalError filter.

[pshenmic]

Thank you, looks good! But some of tests are failing

[coolaj86]

Thank you, looks good! But some of tests are failing

I'll take a look in a few hours to update the tests.

I guess someone decided to update them to pass rather than figure out why they were failing the first time? 🤷‍♂️

It obviously should only retry 60 times when there's an error that is known to be temporary (verifying the blocks) and not for things like authentication errors or bad host and port.

[coolaj86]

Note: This is NOT a deal-breaker (because it's not even our fault), but zeromq errors are still silenced: zeromq/zeromq.js#574

A possible workaround may be to test the connection beforehand by opening a TCP socket and reporting any error.

Or maybe just setting a timeout.

[coolaj86]

bump