Skip to content

feat: Add failure policy to actor reminders#1643

Open
javier-aliaga wants to merge 3 commits intodapr:masterfrom
javier-aliaga:actor-reminder-failure-policies
Open

feat: Add failure policy to actor reminders#1643
javier-aliaga wants to merge 3 commits intodapr:masterfrom
javier-aliaga:actor-reminder-failure-policies

Conversation

@javier-aliaga
Copy link
Contributor

Description

Support actor reminder failure policy

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1625

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga javier-aliaga marked this pull request as ready for review February 6, 2026 15:42
@javier-aliaga javier-aliaga requested review from a team as code owners February 6, 2026 15:42
@javier-aliaga javier-aliaga modified the milestone: v1.17 Feb 6, 2026
@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 88.23529% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.26%. Comparing base (60f01d9) to head (d2e24cc).

Files with missing lines Patch % Lines
.../io/dapr/actors/runtime/ActorObjectSerializer.java 89.28% 0 Missing and 3 partials ⚠️
...in/java/io/dapr/actors/runtime/DaprClientImpl.java 50.00% 1 Missing and 1 partial ⚠️
...rc/main/java/io/dapr/utils/FailurePolicyUtils.java 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1643      +/-   ##
============================================
+ Coverage     79.22%   79.26%   +0.03%     
- Complexity     2137     2146       +9     
============================================
  Files           233      234       +1     
  Lines          6437     6471      +34     
  Branches        697      709      +12     
============================================
+ Hits           5100     5129      +29     
  Misses          986      986              
- Partials        351      356       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


return new ActorReminderParams(data, dueTime, period);
// Handle failure policy if present
JsonNode failurePolicyNode = node.get("failurePolicy");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javier-aliaga What are your thoughts on creating a class and deserialize this failurePolicy into that ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support actor reminder failure policy

3 participants