Change height checks to integrated MC method#601
Open
Shad0wlife wants to merge 1 commit intodan200:masterfrom
Open
Change height checks to integrated MC method#601Shad0wlife wants to merge 1 commit intodan200:masterfrom
Shad0wlife wants to merge 1 commit intodan200:masterfrom
Conversation
This effectively still checks if its 0<=y<256, just as separate checks for 0 and world.getHeight() would do. But by using this, mods like CubicChunks which modify the height limits can change the result of the world.isOutsideBuildHeight() for easy compatibility.
|
Could make a copy of this PR for CC:Tweaked too (if this bugfix already wasnt added there)? |
Contributor
|
CC:T should have these patches already. That said, I've never actually tested whether it's sufficient to ensure compat with CubicChunks. |
Author
|
You are right, thank you. I did not know about CC:Tweaked though, is there any web presence other than your github? When looking for the current version of CC, I did not find anything about it either. EDIT: Ok, found it on Curseforge now that I knew where to look. I hope it gets known better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This effectively still checks if the target position is 0<=y<256, just as separate checks for 0 and world.getHeight() would do.
But by using this, mods like CubicChunks which modify the world's height limits can change the result of the world.isOutsideBuildHeight() for easy compatibility.