RFC: Replace ILuaContext with a non-blocking alternative#574
Open
SquidDev wants to merge 2 commits intodan200:masterfrom
Open
RFC: Replace ILuaContext with a non-blocking alternative#574SquidDev wants to merge 2 commits intodan200:masterfrom
SquidDev wants to merge 2 commits intodan200:masterfrom
Conversation
This is an initial prototype for ways we could better integrate Lua's asynchronous functionality (coroutines) with peripherals and other Lua APIs. The existing system assumes that coroutines each have a backing thread, and so yields will suspect the current thread. This takes inspiration from various "promise" libraries - asynchronous operations (such as executing on the main thread or waiting for an event) return a promise - the result of which can be consumed with `.then`. While I am not aware of plans to change the Lua implementation, this does give us greater flexibility in the future, leading the way for Rembulan, single-threaded Cobalt, and even possibly OC support.
This is definitely a little ugly in places, mostly due to how we've handled backwards compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial prototype for ways we could better integrate Lua's asynchronous functionality (coroutines) with peripherals and other Lua APIs.
The existing system assumes that coroutines each have a backing thread, and so yields will suspect the current thread. This takes inspiration from various "promise" libraries - asynchronous operations (such as executing on the main thread or waiting for an event) return a promise - the result of which can be consumed with
.then.This is very much WIP - there's some things I'd like to do before considering this "ready":
Usage
Just a couple of diffs to show how the old and new APIs compare:
As you can see, there's not really a lot different - it's just a rather tedious refactor. That said, executing things in loops does end up being much uglier, compare this to this. I don't think this is a major issue, as most people won't need to do this, but is worth bearing in mind.