Fix pre-release job in Github actions to stop PR failures
#479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on pull requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix the failing jobs we talked about like 2 weeks ago.
the problem is that
GITHUB_TOKENseems to not be available in jobs started by a PR.as pre-release should only be relevant for you if you push to main anyway, I added this as a condition,
so that pre-release is not triggered anymore by pull requests.
I have only limited experience with GitHub actions, but this solution seems correct to me after skimming the docs. we could also try to check that
github.event_name == 'pull_request'is not fulfilled, alternatively.also, for some reason the
marvinpinto/action-automatic-releasesrepo that is used has a bunch of Chinese (I think) stuff in it, so if you look at the report generated from the failing job, you're first spammed with a bunch of gibberish, which has nothing to do with the problem (well if so that would make it more interesting)also very interesting to me: the job did not fail for this PR. so apparently the code changes here already influence CI. didn't expect that, and also sounds like an awful security backdoor to me?!? very sus.
on the bright side, my error diagnosis seems correct.