Fix custom inspection in new Node.js versions#507
Open
BridgeAR wants to merge 1 commit intocujojs:masterfrom
Open
Fix custom inspection in new Node.js versions#507BridgeAR wants to merge 1 commit intocujojs:masterfrom
BridgeAR wants to merge 1 commit intocujojs:masterfrom
Conversation
Newer Node.js versions export a special symbol that should be used to custom inspect objects. Otherwise the object itself would be poluted. This adds the symbol in the most backwards compatible way possible: it prevents any deprecation message from showing up and behaves just as before. Otherwise the custom inspection will break in Node.js 11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer Node.js versions export a special symbol that should be used
to custom inspect objects. Otherwise the object itself would be
poluted.
This adds the symbol in the most backwards compatible way possible:
it prevents any deprecation message from showing up and behaves just
as before. Otherwise the custom inspection will break in Node.js 11.
I am not sure if it is the best way to tackle this, so I did not add any tests.