Refactor when.guard to be more flexible. (experimental)#439
Open
ChrisEineke wants to merge 1 commit intocujojs:masterfrom
ChrisEineke:guard-refactor
Open
Refactor when.guard to be more flexible. (experimental)#439ChrisEineke wants to merge 1 commit intocujojs:masterfrom ChrisEineke:guard-refactor
ChrisEineke wants to merge 1 commit intocujojs:masterfrom
ChrisEineke:guard-refactor
Conversation
Member
|
@ceineke Thanks for working on this, and sorry it took me a bit to get back to you. I took a quick look and I like the direction (switching to an object). I'll give it a more thorough look soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@briancavalier , this should make guard a little more flexible. What do you think?