Added count parameter to summon and properly checks for invalid parameters#241
Open
12xx12 wants to merge 1 commit intocuberite:masterfrom
Open
Added count parameter to summon and properly checks for invalid parameters#24112xx12 wants to merge 1 commit intocuberite:masterfrom
12xx12 wants to merge 1 commit intocuberite:masterfrom
Conversation
Member
|
Keep in mind that the command should resemble the vanilla equivalent, or at the very least allow for running vanilla commands without conflicts. The count parameter currently occupies the slot for NBT data. Although we don't support NBT tags at the moment, support should be introduced at some point. |
Member
Author
|
Hm.. You are right. I'm gonna keep the rephrasing of the Split Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just wanted to summon multiple entities at once... Now the core plugin can do this.
And I noticed that you could enter 3 additional parameters. The additional parameter would be ignored, but no error was shown. I rephrased the check to be more understandable (hopefully)