Change ID validation for insert operation to detect non-int values#115
Open
Owly-dabs wants to merge 1 commit intocstack:masterfrom
Open
Change ID validation for insert operation to detect non-int values#115Owly-dabs wants to merge 1 commit intocstack:masterfrom
Owly-dabs wants to merge 1 commit intocstack:masterfrom
Conversation
User should not be able to execute an operation as such: ``` db > insert somestring myuser myemail ``` Right now, the user may execute the above command and get the following when using `db > select`: ``` (0, myuser, myemail) ``` `atoi` returns 0 for invalid input. Thus, the invalid `PrepareResult` status `PREPARE_NEGATIVE_ID` should be returned if `int id = 0`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User should not be able to execute an operation as such:
Right now, the user may execute the above command and get the following when using
db > select:atoireturns 0 for invalid input. Thus, the invalidPrepareResultstatusPREPARE_NEGATIVE_IDshould be returned ifint id = 0.