feat: add options page

[ayoung19]

TODO:

• open options page from market still doesnt work in firefox

[Step7750]

Page layout looks good!

There's a couple of remaining pieces

• System for fetching/storing settings (with defaults defined)
• Defining settings for each piece, hooking it to the relevant function
• Adding a "easy" settings button in some places of the UI (ie. in the little float bar in the Steam Market)

I think we should create a new WIP branch to merge the settings PRs into until it is ready for deployment. Otherwise, it makes it difficult to create releases on master.

[ayoung19]

oh i was planning on finishing up the pr on this branch and merging it when it's ready, it's still kind of a draft

[Step7750]

Converted to a draft PR in the meantime, please click Ready for review when you're ready!

Putting it all in one PR is fine with me.

[Step7750]

If we define the options that are possible in a schema (or just their own Setting<name, type, data_type>), then we can also define the description and auto-generate the entire page here.

Adding new settings would become super-simple, just adding the new defined Setting option and it all "hooks" up and allows toggling it here.

[ayoung19]

i agree it would be really nice once we’ve fleshed out more settings and define specific data types but it feels like an over optimization right now

[ayoung19]

would it be fair to add this once we have a third repeating data type for our settings

[ayoung19]

actually at the very least i’ll component-ize this boolean setting field rn

[Step7750]

Sure, I think my solution is a bit of over-engineering for this. But yeah, let's prioritize making it simple to add new options fields.

[Step7750]

It seems like the PR doesn't build:

[webpack-cli] HookWebpackError: Maximum call stack size exceeded

Also looks like the build rule caught a circular dependency.

[dduart3]

May I know if this PR is going to be merged?

[dduart3]

@Step7750

[Step7750]

May I know if this PR is going to be merged?

I believe there were some issues with getting this to run properly on Firefox at one point. If you'd like to fork it, feel free.

[ayoung19]

Also one of the build tools that checks for import cycles wasn't happy, I can take a look there really only is like 1% left to get this merged.

[dduart3]

Also one of the build tools that checks for import cycles wasn't happy, I can take a look there really only is like 1% left to get this merged.

I was just checking this branch, it looked good and built correctly, I was looking to create something like this but this is already too advanced to be discarded imo. I would just change some minor details and add a couple options that I have in mind already.

I'm not sure at all about the issue you're mentioning, it already passed the checks but I would love to see this being merged or approved for merge at least

[ayoung19]

Basically the CI has a circular dependency check that isn't passing because it doesn't seem to like the import cycles that exist in React (which is normal).

But yeah how about I try fix up those two small issues preventing it to be merged and then you can build on top of that.

[dduart3]

Basically the CI has a circular dependency check that isn't passing because it doesn't seem to like the import cycles that exist in React (which is normal).

But yeah how about I try fix up those two small issues preventing it to be merged and then you can build on top of that.

Sounds really good man, would be happy to help if you need it of course

[ayoung19]

Yeah the bigger issue is the link to the options page (from the listing page) doesn't work on Firefox for whatever reason... A fresh pair of eyes may help with that.

[dduart3]

Yeah the bigger issue is the link to the options page (from the listing page) doesn't work on Firefox for whatever reason... A fresh pair of eyes may help with that.

Sure thing man, I'll look into it

[ayoung19]

@Step7750 Omg... This was the problem the whole time 😭

extension/src/lib/bridge/client.ts

Line 8 in 262a725

return !(isFirefox() && inPageContext());

[dduart3]

@Step7750 Omg... This was the problem the whole time 😭

extension/src/lib/bridge/client.ts

Line 8 in 262a725

return !(isFirefox() && inPageContext());

is it working now? haha

[ayoung19]

No, I totally missed that the content script <-> background messaging isn't supported for firefox. @Step7750 any input on how you want this to be fixed?

[Step7750]

No, I totally missed that the content script <-> background messaging isn't supported for firefox. @Step7750 any input on how you want this to be fixed?

Sorry, it has been a long time (hope you're doing well @ayoung19 !)

Content Script/Background Messaging is supported on Firefox using the postMessage fallback bus:

extension/src/lib/bridge/client.ts

Line 43 in 262a725

return g_PostMessageBus.sendRequest(bundle);

[ayoung19]

@Step7750 Thanks and hope you're doing well too! Also yes you're right I took another look and found that it's because I was calling ClientSend(OpenOptionsPage, undefined) instead of ClientSend(OpenOptionsPage, {}). It works now!

Also I noticed the 3D screenshot buttons are gone now so it seems like that option is deprecated. Do you have a new options you'd like added? Would love to finally close this PR.