fix: debank token parsing #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinsho
force-pushed
the
fix/debank-token-parsing
branch
from
0c0c923 to
8af9f12
Compare
galvanizze
reviewed
Feb 10, 2026
blockapi/v2/api/debank.py
Outdated
| app = self._parse_app(item) | ||
| try: | ||
| app = self._parse_app(item) | ||
| except Exception as e: |
Member
There was a problem hiding this comment.
too general exception, what can happen?
Contributor
Author
There was a problem hiding this comment.
Well I'm looking that other parsers don't have the try catch at all, it's handled at the chaingate level. So it makes sense to me to remove them completely.
Vinsho
force-pushed
the
fix/debank-token-parsing
branch
from
228bf6b to
f6ec311
Compare
galvanizze
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.