Add UPDATE, DELETE support, fix escaped quotes, detect invalid SQL#4
Open
nerdrew wants to merge 2 commits intocryodex:masterfrom
Open
Add UPDATE, DELETE support, fix escaped quotes, detect invalid SQL#4nerdrew wants to merge 2 commits intocryodex:masterfrom
nerdrew wants to merge 2 commits intocryodex:masterfrom
Conversation
- add UPDATE - add DELETE FROM - add LIMIT - add FOR UPDATE - add DISTINCT - add COALESCE function - fix selecting literals, e.g. (1 + 1) - refactor racc - fix escaped quotes (both \' and '') - better detection of invalid sql (e.g. SELECT1)
Author
|
Ok, punted on splitting into smaller PRs. They conflict too much. Is this change too large to review? |
|
I can review it, but I couldn't merge it so not sure if the repo owner might find it too big? |
Author
|
@cryodex Do you have an opinion? |
Author
|
@louismullie Thoughts on this PR? |
- fix COALESCE with multiple arguments - add support for sql functions - fix 1e1, 1E1 literals: don't match identifiers that start with "e"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @ggilder @maniksurtani @zanker