Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Okta SDK from v2 to v6, requiring significant changes to adapt to the new SDK's API structure and data types. The upgrade necessitates handling profile types differently (supporting both OktaUserGroupProfile and OktaActiveDirectoryGroupProfile) and using getter methods instead of direct field access.
- Migration from Okta SDK v2 to v6 with updated import paths and API client initialization
- Refactored group and user data access to use getter methods and handle multiple profile types
- Updated test fixtures to include additional required fields for v6 SDK compatibility
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Updates Okta SDK dependency from v2.20.0 to v6.0.1 and associated transitive dependencies |
| internal/okta/client.go | Refactors client initialization for v6 SDK, adds custom server configuration for testing, and updates API method calls to use new v6 patterns |
| internal/okta/groups.go | Changes group handling to support multiple profile types and uses getter methods instead of direct field access |
| fixtures/scenarios.json | Expands test fixture JSON responses with additional required fields for v6 SDK compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.